Jupyter tile, merge cert info from old notebook to avoid loss #2750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-6455
Description
Merges in the volumeMounts, and the notebook container's volumes & envs to keep the cert information around instead of overriding it with the k8s patch logic.
How Has This Been Tested?
Manually using the Jupyter tile.
Needs self signed cert stuff setup (cc @harshad16 for details)
ca-bundle
references)ca-bundle
referencesTest Impact
None, backend only change.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
/cc @harshad16